Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Station Bank Deposits #361

Merged
merged 4 commits into from
Oct 2, 2023
Merged

Conversation

dvir001
Copy link
Contributor

@dvir001 dvir001 commented Sep 27, 2023

About the PR

Allow the SE to deposit money back into the bank, needed for SR mistakes, fines and recovered assets from sells related to contraband found by security.

Why / Balance

Much needed and requested.

Technical details

Added a new deposit function to the station bank computer, this one isn't the same as the normal ATM since it require you to provide logic for logs when you insert money into it, and also allow multi deposits to be done to the inserted money.

Media

On the discord
https://discord.com/channels/1123826877245694004/1127687656084611214/1156642734174634034

Breaking changes

None, testes it to make sure it wont have exploits or issues.

Changelog
🆑 dvir01

  • tweak: NT Now allows the SR to deposit money into the station bank.

@Cheackraze Cheackraze self-requested a review September 30, 2023 22:05
Copy link
Member

@Cheackraze Cheackraze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you've got some unnecessary stuff in here. Does the staiton rep need a reason for deposit? I think we should just allow it without a reason or description.

Content.Server/Cargo/Systems/CargoSystem.Orders.cs Outdated Show resolved Hide resolved
@dvir001
Copy link
Contributor Author

dvir001 commented Sep 30, 2023

I think you've got some unnecessary stuff in here. Does the staiton rep need a reason for deposit? I think we should just allow it without a reason or description.

Its for RP, the SR job is a lot about paper work and it feel right to have you require to note it.

@Cheackraze Cheackraze merged commit d777209 into new-frontiers-14:master Oct 2, 2023
13 of 15 checks passed
FrontierATC added a commit that referenced this pull request Oct 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants